Skip to content

Conversation

@Anemy
Copy link
Member

@Anemy Anemy commented May 28, 2025

DEBUG: ${debug|}
script: |
set -e
npm run --unsafe-perm --workspace @mongodb-js/compass-web compile
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need --unsafe-perm everywhere? Should we make it part of compass-env as npm_config_unsafe_perml: true instead of adding it to every command line?

Copy link
Member Author

@Anemy Anemy May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Not needed here, removed it. I'll keep an eye out for when we have it in the future, setting it up in the config would be a good move if we do need it. Not sure if it's needed in some of the other tasks that have it specified.

@Anemy Anemy marked this pull request as ready for review May 28, 2025 19:48
@Anemy Anemy merged commit 5952806 into main May 29, 2025
58 checks passed
@Anemy Anemy deleted the COMPASS-9415-bundle-compass-web-evergreen-test branch May 29, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants